Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving the tests #618

Merged
merged 21 commits into from
Jun 9, 2024
Merged

Improving the tests #618

merged 21 commits into from
Jun 9, 2024

Conversation

bruAristimunha
Copy link
Collaborator

closes #617

bruAristimunha
bruAristimunha commented Jun 8, 2024
View reviewed changes
moabb/tests/evaluations.py Show resolved Hide resolved
moabb/tests/evaluations.py Show resolved Hide resolved
@bruAristimunha bruAristimunha mentioned this pull request Jun 8, 2024
Open
@bruAristimunha
Copy link
Collaborator Author

Hi @sylvchev,

Suppose we merge this PR and PR #618. It's all good for me to make the release.

@sylvchev
Copy link
Member

sylvchev commented Jun 9, 2024

@bruAristimunha You mean this PR (#618) and the PR #622?

@bruAristimunha
Copy link
Collaborator Author

bruAristimunha commented Jun 9, 2024 •
edited
Loading

Yes! 1) Tests and 2) import @sylvchev

sylvchev
sylvchev approved these changes Jun 9, 2024
View reviewed changes
moabb/tests/evaluations.py Show resolved Hide resolved
moabb/tests/evaluations.py Show resolved Hide resolved
@sylvchev sylvchev merged commit 02902d6 into NeuroTechX:develop Jun 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvchev sylvchev sylvchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace the unitest for pytest
2 participants
@bruAristimunha @sylvchev