Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to update schema files and update schema files #28

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented Apr 28, 2018

No description provided.

jcfr and others added 4 commits April 28, 2018 01:09
Run the UpdateFromUpstream.sh script to extract upstream nwb-schema
using the following shell commands.

$ git archive --prefix=upstream-nwb-schema/ e1f52504 -- 
  core
   | tar x


Initial import of e1f52504b3c3b050ab54bb6fbf0e6a818f537c0f
…update-schema

* upstream-nwb-schema:
  nwb-schema 2018-04-26 (e1f52504)

# Conflicts:
#	schema/core/nwb.base.yaml
#	schema/core/nwb.ecephys.yaml
#	schema/core/nwb.epoch.yaml
#	schema/core/nwb.file.yaml
#	schema/core/nwb.misc.yaml
#	schema/core/nwb.ogen.yaml
#	schema/core/nwb.ophys.yaml
@jcfr
Copy link
Contributor Author

jcfr commented Apr 28, 2018

This PR introduces a script similar to what was done in NeurodataWithoutBorders/pynwb#506

Worth noting that schema files used in matnwb were updated in 7947b3d to match the latest version available in nwb-schema project.

That said, commit 6186d0b reverted some of the change. These updates specific to matnwb can be viewed looking at 0771f98 associated with this PR.

It would be great to either:

  • update the official schema
  • improve matnwb so that it can make use of the official schema

If some of these differences are required, we could also make use of a snapshot_redact_cmd in script schema/core/UpdateFromUpstream.sh

@bendichter
Copy link
Contributor

I'd like to update the schema in matnwb and keep it up to date with pynwb and nwb-schema. Is that what this PR is trying to do? I tried generating the core using the schema in the latest pynwb dev branch:

generateCore('path_to/pynwb/src/pynwb/data/nwb.namespace.yaml');
nwbRead('path_to/resting_state.nwb')

and it worked without an error :-)

@bendichter
Copy link
Contributor

nudge @nclack

@lawrence-mbf lawrence-mbf merged commit e9e4390 into NeurodataWithoutBorders:master Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants