Add script to update schema files and update files #506
Conversation
Script "UpdateThirdPartyFromUpstream.sh" was copied from InsightSoftwareConsortium/ITK@4c3dd8c
* Allow the script to be executed from anywhere * snapshot_relative_path can now be set to the directory where the files should be integrated * Initial import updated to work with non-empty directory
Run the UpdateFromUpstream.sh script to extract upstream nwb-schema using the following shell commands. $ git archive --prefix=upstream-nwb-schema/ e1f52504 -- core | tar x Initial import of e1f52504b3c3b050ab54bb6fbf0e6a818f537c0f
* upstream-nwb-schema: nwb-schema 2018-04-26 (e1f52504) # Conflicts: # src/pynwb/data/nwb.file.yaml # src/pynwb/data/nwb.ogen.yaml
| github_compare=true | ||
|
|
||
| snapshot_author_name='nwb-schema Upstream' | ||
| snapshot_author_email='neurodatawithoutborders@googlegroups.com' |
There was a problem hiding this comment.
@oruebel If this sounds reasonable, is it something you could do ?
There was a problem hiding this comment.
@jcfr what is the purpose of linking nwb-bot to the googlegroup?
There was a problem hiding this comment.
This allows to have commit message done by the bot to have an email, allowing it to link back to the bot account.
The email doesn't have to be verified, it should just be added in the settings.
Codecov Report
@@ Coverage Diff @@
## dev #506 +/- ##
==========================================
- Coverage 71.47% 71.45% -0.02%
==========================================
Files 57 57
Lines 6099 6099
Branches 1173 1173
==========================================
- Hits 4359 4358 -1
Misses 1422 1422
- Partials 318 319 +1
Continue to review full report at Codecov.
|
|
@lawrence I am planning to update matnwb adding a script similar to src/pynwb/data/UpdateFromUpstream.sh |
|
Our current workflow is to make changes to the schema in pynwb and then copy those over to nwb-schema. This PR would add a script to do the reverse - it copies the schema from nwb-schema over to pynwb. As such, we are closing this PR. We could change the script to do the reverse if this is desired. |
No description provided.