Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ophys/imaging_rate: use float instead of text #155

Closed
wants to merge 1 commit into from

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented Apr 28, 2018

See #136

@jcfr jcfr changed the title ophys/imaging_rate: use float instead of str ophys/imaging_rate: use float instead of text Apr 28, 2018
@jcfr jcfr force-pushed the ophys-imageing-rate-use-float branch from 93a4cf2 to 33fd130 Compare April 28, 2018 06:17
@oruebel
Copy link
Contributor

oruebel commented Apr 30, 2018

@jcfr did you update the schema and API class in PyNWB API for this too?

@jcfr
Copy link
Contributor Author

jcfr commented May 10, 2018

did you update the schema and API in PyNWB API for this too?

No.

As soon as the change are integrated in this repo, anyone will be able to run the pynwb script ./src/pynwb/data/UpdateFromUpstream.sh to sync with the updated schema

(@oruebel to enable this, would appreciate if you could review NeurodataWithoutBorders/pynwb#506)

Now the update of the API would have to be done as part of the PR updating the schema in pynwb. May be @bendichter could take care of this ?

@oruebel
Copy link
Contributor

oruebel commented May 10, 2018

@jcfr do I understand this correctly that the workflow here is to update the schema in nwb-schema first and to then catch up PyNWB to it? For consistency, it might be easier to do this the other way around, i.e. update the schema and API in PyNWB first and then push out the changes to nwb-schema.

@jcfr
Copy link
Contributor Author

jcfr commented Jun 30, 2018

workflow here is to update the schema in nwb-schema first and to then catch up PyNWB to it?

Indeed.

it might be easier to do this the other way around, i.e. update the schema and API in PyNWB first and then push out the changes to nwb-schema.

Definitively agree 👍

@oruebel
Copy link
Contributor

oruebel commented Sep 12, 2018

The schema in PyNWB has changed quite a bit. I've ported and finished the changes in PyNWB (i.e., updated the container class and added tests). The changes will move over the this repo when we copy the schema from PyNWB to here. Closing this PR. The current PR for this is on the PyNWB repo here NeurodataWithoutBorders/pynwb#612

@oruebel oruebel closed this Sep 12, 2018
@oruebel oruebel deleted the ophys-imageing-rate-use-float branch September 12, 2018 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants