Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change datatype (from str->float) of emission and excitation wavelengths (lambdas) and imaging rate #137

Closed
wants to merge 4 commits into from

Conversation

bendichter
Copy link
Contributor

fix #136

ajtritt
ajtritt previously approved these changes Apr 2, 2018
@t-b
Copy link
Contributor

t-b commented Apr 23, 2018

@bendichter Any specifc reason to use float32? AFAIR you can use float to denote either float32 or float64.

@bendichter
Copy link
Contributor Author

bendichter commented Apr 23, 2018 via email

@tjd2002 tjd2002 changed the title change wavelength and excitation lambdas to float change emission and excitation wavelengths (lambdas) to float Apr 26, 2018
@tjd2002 tjd2002 changed the title change emission and excitation wavelengths (lambdas) to float change datatype (from str->float) of emission and excitation wavelengths (lambdas) and imaging rate Apr 26, 2018
@jcfr
Copy link
Contributor

jcfr commented Apr 28, 2018

Closing. Superseded by #154 and #155

@jcfr jcfr closed this Apr 28, 2018
@jcfr jcfr deleted the str->float branch April 28, 2018 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change ophys.ImagingPlane fields excitation_lambda and imaging_rate from str to float
4 participants