Skip to content

Commit

Permalink
Replace "elevation" in RNTester rows with box-shadow (facebook#46076)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#46076

This will add the shadows to iOS as well. let's see if anyone notices 🙂. I also removed dead styles, and removed some of the extra (excessive) padding specific to Android where the previous shadows would overlap.

Changelog: [Internal]

Differential Revision: D61421903
  • Loading branch information
NickGerleman authored and facebook-github-bot committed Aug 17, 2024
1 parent a28614c commit 48db6f4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 17 deletions.
12 changes: 4 additions & 8 deletions packages/rn-tester/js/components/RNTPressableRow.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,20 +70,16 @@ const styles = StyleSheet.create({
justifyContent: 'center',
paddingHorizontal: 15,
paddingVertical: 12,
marginVertical: Platform.select({ios: 4, android: 8}),
marginHorizontal: 15,
overflow: 'hidden',
elevation: 5,
backgroundColor: Platform.select({ios: '#FFFFFF', android: '#F3F8FF'}),
marginVertical: 4,
marginHorizontal: 16,
experimental_boxShadow: '0 2px 4px -1px rgba(0, 0, 0, 0.25)',
borderRadius: 8,
},
descriptionText: {
fontSize: 12,
lineHeight: 20,
marginBottom: 5,
},
pressed: {
elevation: 3,
},
topRowStyle: {
flexDirection: 'row',
justifyContent: 'space-between',
Expand Down
9 changes: 0 additions & 9 deletions packages/rn-tester/js/components/RNTesterModuleList.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,15 +144,6 @@ const styles = StyleSheet.create({
fontWeight: '500',
fontSize: 11,
},
row: {
justifyContent: 'center',
paddingHorizontal: 15,
paddingVertical: 12,
marginVertical: Platform.select({ios: 4, android: 8}),
marginHorizontal: 15,
overflow: 'hidden',
elevation: 5,
},
topRowStyle: {
flexDirection: 'row',
justifyContent: 'space-between',
Expand Down

0 comments on commit 48db6f4

Please sign in to comment.