Replace "elevation" in RNTester rows with box-shadow #46076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61421903 |
|
This pull request was exported from Phabricator. Differential Revision: D61421903 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Aug 17, 2024
Summary: Pull Request resolved: facebook#46076 This will add the shadows to iOS as well. let's see if anyone notices 🙂. I also removed dead styles, and removed some of the extra (excessive) padding specific to Android where the previous shadows would overlap. Changelog: [Internal] Differential Revision: D61421903
NickGerleman
force-pushed
the
export-D61421903
branch
from
2cd7b1f to
588de8a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61421903 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Aug 17, 2024
Summary: Pull Request resolved: facebook#46076 This will add the shadows to iOS as well. let's see if anyone notices 🙂. I also removed dead styles, and removed some of the extra (excessive) padding specific to Android where the previous shadows would overlap. Changelog: [Internal] Differential Revision: D61421903
NickGerleman
force-pushed
the
export-D61421903
branch
from
588de8a to
8063707
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61421903 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Aug 17, 2024
Summary: Pull Request resolved: facebook#46076 This will add the shadows to iOS as well. let's see if anyone notices 🙂. I also removed dead styles, and removed some of the extra (excessive) padding specific to Android where the previous shadows would overlap. Changelog: [Internal] Differential Revision: D61421903
NickGerleman
force-pushed
the
export-D61421903
branch
from
8063707 to
bd3cbda
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61421903 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Aug 17, 2024
Summary: Pull Request resolved: facebook#46076 This will add the shadows to iOS as well. let's see if anyone notices 🙂. I also removed dead styles, and removed some of the extra (excessive) padding specific to Android where the previous shadows would overlap. Changelog: [Internal] Differential Revision: D61421903
NickGerleman
force-pushed
the
export-D61421903
branch
from
bd3cbda to
b3baa9f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61421903 |
NickGerleman
force-pushed
the
export-D61421903
branch
from
b3baa9f to
48db6f4
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Aug 17, 2024
Summary: Pull Request resolved: facebook#46076 This will add the shadows to iOS as well. let's see if anyone notices 🙂. I also removed dead styles, and removed some of the extra (excessive) padding specific to Android where the previous shadows would overlap. Changelog: [Internal] Differential Revision: D61421903
|
This pull request was exported from Phabricator. Differential Revision: D61421903 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Aug 20, 2024
Summary: Pull Request resolved: facebook#46076 This will add the shadows to iOS as well. let's see if anyone notices 🙂. I also removed dead styles, and removed some of the extra (excessive) padding specific to Android where the previous shadows would overlap. Changelog: [Internal] Reviewed By: rshest Differential Revision: D61421903
NickGerleman
force-pushed
the
export-D61421903
branch
from
48db6f4 to
57929c2
Compare
Summary: Pull Request resolved: facebook#46076 This will add the shadows to iOS as well. let's see if anyone notices 🙂. I also removed dead styles, and removed some of the extra (excessive) padding specific to Android where the previous shadows would overlap. Changelog: [Internal] Reviewed By: rshest Differential Revision: D61421903
|
This pull request was exported from Phabricator. Differential Revision: D61421903 |
NickGerleman
force-pushed
the
export-D61421903
branch
from
57929c2 to
aaf614d
Compare
|
This pull request has been merged in d713349. |
|
This pull request was successfully merged by @NickGerleman in d713349 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This will add the shadows to iOS as well. let's see if anyone notices 🙂. I also removed dead styles, and removed some of the extra (excessive) padding specific to Android where the previous shadows would overlap.
Changelog: [Internal]
Differential Revision: D61421903