Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Create a new CucumberJS parser that replaces both CucumberJS parsers #71

Closed
wswebcreation opened this issue Aug 24, 2017 · 0 comments
Assignees

Comments

@wswebcreation
Copy link
Collaborator

Current situation:
Currently protractor-flake for CucumberJS can use 2 parsers, the cucumber.js and the cucumber.multi.js parser. The first parser is based on the logging of the framework for CucumberJS < 0.9.0 and the second one is based on a console.log.

Desired situation:
Replace both parsers with a new parser that will read the log based on a console.log users need to add to their framework. This is currently already advised for CucumberJS 1.
The advantage of parsing the log of protractor based on a console.log is that it will be more stable and framework independent then the current parsing because that one is based on the logging of the framework itself.

To do:

  • [] create a new parser called cucumber, the other ones will be removed and this will result in a new major release
  • [] test this for CucumberJS 1, 2 and 3
  • [] create new unit tests
  • [] create new docs for cucumber with examples how to implement this for CucumberJS 1, 2 and 3
@wswebcreation wswebcreation self-assigned this Aug 24, 2017
wswebcreation added a commit to wswebcreation/protractor-flake that referenced this issue Aug 31, 2017
This change simplifies the cucumber parsers and brings them down to 1 parser.
The docs are also updated with usage examples.

Closes NickTomlin#71

BREAKING CHANGE: cucumberMulti parser can't be used anymore

To migrate change `cucumberMulti` to `cucumber`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant