feat: add support for jasmine-spec-reporter (displayStacktrace: true)

[qualityshepherd]

Adds support for jasmine-spec-reporter to standard parser. Also, very likely resolves #54

[qualityshepherd]

@NickTomlin there seems to be a bug either in your transpile, or my brain, because my change here is not making it into the dist folder. My money's on my brain 'cause I don't totally get what you're doing here.

It works in isolation (eg. when I run the unit tests), but it's not updating the dist folder, when including in my protractor project.

That said, this simple change should fix #54 that folks (and myself) are having.

[NickTomlin]

Awesome!

Could you add a spec for this?

I'll take a transpilation stuff. Update: it's building for me locally. What happens when you run npm run build?

[qualityshepherd]

Ahhh... so this is an issue with jasmine-spec-reporter and Protractor 5.1.2. You're using 4.x, which still prints at Object.<anonymous>. 5.1.2 prints at UserContext.<anonymous>.

You want me to update the protractor version, or just add the output and a unit test (which I'm trying to figure out what the hell you're doing in there :) )?

Update: oh, and the transpile issue was just while I was debugging via node_modules in my code, which was throwing wackiness (stupid transpilers ;) ). It works fine locally.

[NickTomlin]

I'd add a unit test but feel free to bump the protractor version while you are at it.

[qualityshepherd]

(also asked on Gitter)
I added a flakey test output file for jasmine-spec-reporter, and the following unit test:

    it('isolates individual failed specs from jasmine-spec-reporter output', () => {
      protractorFlake({maxAttempts: 3})

      spawnStub.dataCallback(failedJasmineSpecReporterTestOutput)
      spawnStub.endCallback(1)

      expect(spawnStub).to.have.been.calledWith('node', [pathToProtractor(), '--params.flake.retry', true, '--specs', '/tests/a-flakey.test.js'])
    })

but it's failing with this error:

  1) Protractor Flake failed specs isolates individual failed specs from jasmine-spec-reporter output:
     AssertionError: expected stub to have been called with arguments node, ["/Users/brine/protractor-flake/node_modules/protractor/bin/protractor", "--params.flake.retry", true, "--specs", "/tests/a-flakey.test.js"]%D
      at Context.<anonymous> (test/unit/index.test.js:103:38)

What am I doon wrong?

[qualityshepherd]

Got it... was just braindumb. Ready for review, Nick...

[NickTomlin]

Some very minor changes. Other than that this looks great!

My commit linter is being super unhelpful and breaking the build so I can merge this in myself once you've updated.

[NickTomlin]

I'd remove this file unless we need it since (we don't have an integration test that actually uses it)

[qualityshepherd]

Cool... wasn't sure if you wanted a repeatable conf for the future [WOOSH SOUND]. The answer is no :) It's gone.

[NickTomlin]

Is this dependency actually needed? I'm fine with omitting it since we have generated the static test output

[qualityshepherd]

Not now that the conf using it is gone

[wswebcreation]

@qualityshepherd

Tnx for this PR, I didn't had the time to look at this because the sun didn't let me (something called vacation 😁).

Maybe something not in scope of this change, but is there a way in Jasmine that we can log a line of text to the console on every failed test?

That would make the reading of the log for protractor-flake much easier. Currently working on that for the CucumberJS parser

[qualityshepherd]

@wswebcreation yeah, definitely out of scope for this pr, but would be easy enough to do...

@NickTomlin all wrapped up. Though one last question... do we want this fix in multi too?

[wswebcreation]

@qualityshepherd

I would advice to also fix the multi

Secondly, if it's easy to fix for Jasmine with a logline, can you give me a direction so I can create aPR for CucumberJS and Jasmine with examples?

[NickTomlin]

@wswebcreation @wswebcreation great point on multi, I always forget about that one :( I think we should!

It would be interesting to expose separate reporters for jasmine/cucumber that do this logging. Let's keep that discussion going in another PR. Do one of you want to open up an issue to track it?

[wswebcreation]

Will create an issue for this

[qualityshepherd]

@NickTomlin cool... that was easy, as the multi parser doesn't needs a change for this. So I just added a unit test.

[wswebcreation]

@NickTomlin and @qualityshepherd

I've created 2 new issues (Feature request), #71 and #72.

[NickTomlin]

I've gone ahead and removed conventional changelog linting on master, so could you rebase to re-run the integration tests? In my other runs it seems like bumping protractor breaks the integration tests. We should either fix them or downgrade for now and bump later.

Edit: we can bump the version but we'll need to drop node 4+5 from the builds (and we should probably add 8 while we are there)

[NickTomlin]

I went ahead and made these changes myself and merged this in. Thanks!

[qualityshepherd]

Cool... thanks Nick!