Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer overflow while adding OTP #155

Closed
szszszsz opened this issue Sep 23, 2016 · 0 comments
Closed

Buffer overflow while adding OTP #155

szszszsz opened this issue Sep 23, 2016 · 0 comments
Assignees
@szszszsz
Milestone
0.5.1

Comments

@szszszsz
Copy link
Member

szszszsz commented Sep 23, 2016 •
edited
Loading

Ubuntu 16.04
Nitrokey Pro v0.7, Storage v0.43
Frequency: 2/2
Buffer overflow occurs when adding TOTP in configuration window:

  1. Input name with maximum length
  2. Select secret format hex
  3. Input secret consisting of zeroes with maximum length
  4. Click Save
@szszszsz szszszsz added this to the 0.5.1 milestone Sep 27, 2016
@szszszsz szszszsz added the ready label Oct 3, 2016
szszszsz added a commit that referenced this issue Oct 5, 2016
@szszszsz
Avoid buffer overflow while encoding secret to base32. Fixes #155
bb2333e 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz szszszsz self-assigned this Oct 5, 2016
@szszszsz szszszsz added in progress and removed ready labels Oct 5, 2016
@szszszsz szszszsz mentioned this issue Oct 5, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szszszsz szszszsz

Labels
None yet
Projects
None yet
Milestone
0.5.1
Development

No branches or pull requests
1 participant
@szszszsz