Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid buffer overflow during hex<->base32 conversion #164

Merged
merged 2 commits into from
Oct 5, 2016
Merged

Avoid buffer overflow during hex<->base32 conversion #164

merged 2 commits into from
Oct 5, 2016

Conversation

szszszsz
Copy link
Member

@szszszsz szszszsz commented Oct 5, 2016 •
edited
Loading

Issue #155
Tested on Ubuntu 16.04
Nitrokey Storage v0.43

@szszszsz
Avoid buffer overflow while encoding secret to base32. Fixes #155
af7e3a8 
Code cleanup. Check conditions earlier on function code

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Avoid buffer overflow when decoding secret to hex
e0df2dd 
Set maximum secret length field depending on chosen secret format
Clear buffers before use

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz szszszsz merged commit f440157 into master Oct 5, 2016
@szszszsz szszszsz deleted the 155-buffer_overflow branch October 5, 2016 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@szszszsz