fix up language in the packaging tutorial #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fricklerhandwerk
commented
Jan 28, 2024
fricklerhandwerk
commented
- make many sentences shorter
- add links
- expand on finding things
- use more domain-specific headings
- add next steps
henrik-ch
reviewed
Jan 29, 2024
There was a problem hiding this comment.
I couldn't complete all the way down - thank you for putting in this work @fricklerhandwerk ! ❤️
- make many sentences shorter - add links - expand on finding things - use more domain-specific headings - add next steps
Co-authored-by: Henrik <i97henka@gmail.com>
Co-authored-by: Henrik <i97henka@gmail.com>
fricklerhandwerk
force-pushed
the
packaging-fixups
branch
from
daa1e02 to
fdc012f
Compare
oliviacrain
reviewed
Feb 1, 2024
| @@ -179,7 +214,7 @@ building | |||
| Great news: the derivation built successfully! | |||
|
|
|||
| The console output shows that `configure` was called, which produced a `Makefile` that was then used to build the project. | |||
| It wasn't necessary to write any build instructions in this case because the `stdenv` build system is based on `autoconf`, which automatically detected the structure of the project directory. | |||
| It wasn't necessary to write any build instructions in this case because the `stdenv` build system is based on [GNU Autoconf](https://www.gnu.org/software/autoconf/), which automatically detected the structure of the project directory. | |||
There was a problem hiding this comment.
I think this sentence implies autoconf itself detected the structure of the project, which is incorrect.
There was a problem hiding this comment.
What would you suggest here?
infinisil
approved these changes
Feb 1, 2024
Co-authored-by: Olivia Crain <olivia@olivia.dev>
fricklerhandwerk
force-pushed
the
packaging-fixups
branch
from
43517fb to
48c62b8
Compare
|
Thanks a lot @oliviacrain for the great, diligent review comments! I think we can leave the last one for now and fix it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.