Auto-assign reviewers by file #7229
Conversation
Mic92
changed the title
fricklerhandwerk
changed the title
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2022-10-28-documentation-team-meeting-13/22806/1 |
There was a problem hiding this comment.
- @thufschmitt: we need this because
CODEOWNERSrequires commit access- @edolstra: also it makes an implication of ownership
- @fricklerhandwerk: why is that a problem?
- @edolstra: don't want a too large group of people to have veto power over the code
- @thufschmitt: we can note this in the file, that it does not mean actual onership?
- @fricklerhandwerk: we need both code ownership (and being on the Nix team should come with the right and duty to own code) and a means to notify people who care about changes but don't have merge access
- @tomberek: agreed, we need both
- @thufschmitt: it's quite an expensive routine, but this is GitHub's cost
- also it's silly that maintainers have to press the button on PRs by outside contributors, but we should be able to handle it
- @edolstra: can we have the same thing as in Nixpkgs?
- @fricklerhandwerk: there a bot reads the
maintainersattribute on packages, we can't do that here - @thufschmitt: a bot could read
git blameand assign automatically based on that- @fricklerhandwerk: that would not help notifying people interested in tracking changes and reviewing code before they got anything merged
- @fricklerhandwerk: there a bot reads the
- @edolstra: this is a good change, let's merge this
Decision
undraft and merge
|
This is great, let's merge it. @Mic92 is there anything you'd like to do on this PR before we merge it? Otherwise feel free to un-draft it and I'll merge |
|
Personal comment: Could you document it somewhere? I'm not sure what would be the best place for that (cc @fricklerhandwerk). That probably deserves a custom section under https://github.com/NixOS/nix/tree/master/doc/manual/src/contributing/ |
Ok from my side. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2022-11-04-nix-team-meeting-minutes-6/22998/1 |
|
This doesn't work yet, I guess we need to configure some token or whatever (https://github.com/NixOS/nix/actions/runs/3445124965/jobs/5748478961). |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2022-11-11-nix-team-meeting-notes-7/23451/1 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-06-08-documentation-team-meeting-notes-53/28938/1 |
This was discussed in the documentation meeting to get quicker reviewers on manual related things.