add CODEOWNERS

[fricklerhandwerk]

as a supplement to #7229 as discussed on the Nix team

@edolstra @thufschmitt feel free to add more specifics. Also, who else has merge access and may want to get notified?

[thufschmitt]

👍 from me (although I wouldn't merge it without an agreement from the whole Nix team).

In a "small steps" fashion, I'll refrain from making any addition to the file itself, leaving that for follow-up PRs

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-39/23130/1

[fricklerhandwerk]

Discussed on Nix team meeting 2022-11-11:

• @edolstra: this seems to do a subset of the auto-assign bot's work. let's make sure that works first. no point having two different files denoting responsibilities
  • @thufschmitt: if the bot requires reviewers to be collaborators too, let's stick to CODEOWNERS
  • @edolstra: will try the bot with someone who has no commit access

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2022-11-11-nix-team-meeting-notes-7/23451/1

[fricklerhandwerk]

@edolstra does the review assignment workflow work already? The test PR still fails, but I got assigned to #3600 by some GitHub Action.

[edolstra]

It seems to work sometimes. On the test PR it fails with "Resource not accessible by integration" whatever that means.

[thufschmitt]

I'd suspect it works for PRs that come from the NixOS/nix repo and fail for the others

[fricklerhandwerk]

I that case it's useless, since everyone except maintainers will make PRs from their forks.

PS: Actually I think everyone including maintainers should do this, to keep only branches which serve a clear purpose so they are discoverable.

[thufschmitt]

I that case it's useless, since everyone except maintainers will make PRs from their forks.

Yes, totally agreed

PS: Actually I think everyone including maintainers should do this, to keep only branches which serve a clear purpose so they are discoverable.

I don't think that's too problematic. I agree that using the fork as the base branch is a good default, but it's occasionally useful to create PRs directly from the NixOS repo. For stacked PRs in particular, there's still no good way to do them if all the branches aren't local.

[fricklerhandwerk]

Discussed in the Nix team meeting on 2022-12-05:

• @fricklerhandwerk: this one was opened and closed immediately: .github/workflows/assign-reviewer: switch to pull_request_target #7398
  • @thufschmitt: not clear if it would have helped anyway
    • also auto-assign reviewers requires merge access too
    • should go for CODEOWNERS
  • @edolstra: no strong opinion on this
  • no meaningful alternative to CODEOWNERS
• decision: merge

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2022-12-05-nix-team-meeting-minutes-14/23836/1