Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/assign-reviewer: switch to pull_request_target #7398

Closed
wants to merge 1 commit into from

Conversation

zowoq
Copy link

@zowoq zowoq commented Dec 3, 2022

No description provided.

@ncfavier
Copy link
Member

ncfavier commented Dec 3, 2022

I don't have strong opinions about this, but see actions/first-interaction#10 (comment)

@zowoq
Copy link
Author

zowoq commented Dec 3, 2022

I don't have strong opinions about this, but see actions/first-interaction#10 (comment)

comment != review

@ncfavier
Copy link
Member

ncfavier commented Dec 3, 2022

I'd expect both to fall under the pull-requests scope?

Anyway, I was rather pointing at the potential security risk with pull_request_target. Maybe we should try with

permissions:
  contents: read
  pull-requests: write

first, see if that works?

@zowoq
Copy link
Author

zowoq commented Dec 3, 2022

Maybe we should try with ...

Please do.

@fricklerhandwerk
Copy link
Contributor

Please add a descriptive commit message that does not state what the code change itself already informs us about, i.e. why that change was made.

@zowoq zowoq closed this Dec 5, 2022
@zowoq zowoq deleted the assign branch December 5, 2022 08:26
@fricklerhandwerk fricklerhandwerk mentioned this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants