Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search result elements should be keyboard focusable #258

Closed
jakeisnt opened this issue Dec 31, 2020 · 1 comment · Fixed by #260
Closed

Search result elements should be keyboard focusable #258

jakeisnt opened this issue Dec 31, 2020 · 1 comment · Fixed by #260
Labels

Comments

@jakeisnt
Copy link

Currently, none of the search results can be navigated or selected with keyboard input alone, because they lack the HTML tags that tell the browser how to select them.

Adding the HTML attributes tabindex and role (button) to the heading of each search result would allow these headings to be expanded and contracted without the use of a mouse, which will enable more users to make better use of the site.

@samueldr
Copy link
Member

samueldr commented Dec 31, 2020

In a more natural manner, using <a> (or <button>) element as part of one of the cells, like attribute name, should fix this without requiring tabindex (which can cause problems) or role.

Since they are elements that can be focused using the keyboard naturally in the browser, the browser already knows how to handle them. It is how it was handled before the move to the new Elm app. (I don't have it running anywhere anymore to show that it worked.)

(I changed the title to a more actionable goal)

@samueldr samueldr changed the title Search result elements should have role and tabindex attributes (accessibility) Search result elements should be keyboard focusable Dec 31, 2020
@samueldr samueldr added enhancement New feature or request topic: accessibility labels Dec 31, 2020
turboMaCk added a commit that referenced this issue Jan 5, 2021
- improves usability with keyboard #258
- improves accessbility

See #259 for other relevant discussion
garbas added a commit that referenced this issue Jan 6, 2021
- improves usability with keyboard #258
- improves accessbility

See #259 for other relevant discussion

Co-authored-by: Rok Garbas <rok@garbas.si>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants