Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add semanticaly clickable button element to result list #260

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Add semanticaly clickable button element to result list #260

merged 2 commits into from
Jan 6, 2021

Conversation

turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Jan 5, 2021 •
edited by samueldr
Loading

@turboMaCk
Add semanticaly clicable button element to result list
8e4069b 
- improves usability with keyboard #258
- improves accessbility

See #259 for other relevant discussion
@turboMaCk turboMaCk added enhancement New feature or request question Further information is requested labels Jan 5, 2021
@turboMaCk turboMaCk requested review from garbas and samueldr January 5, 2021 21:00
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2021

🚀 Deployed on https://5ff4d3f3fb27d90b94a564e4--nixos-search.netlify.app

@turboMaCk turboMaCk changed the title Add semanticaly clicable button element to result list Add semanticaly clickable button element to result list Jan 5, 2021
@samueldr
Copy link
Member

samueldr commented Jan 5, 2021

(Edited the description to auto-close relevant issues.)

samueldr
samueldr requested changes Jan 5, 2021
View reviewed changes
src/index.less Show resolved Hide resolved
@samueldr
Copy link
Member

samueldr commented Jan 5, 2021

Good work. Details to fixup in the styles, but otherwise appropriate approach.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2021

🚀 Deployed on https://5ff5cffb4534ce1bb253f8b1--nixos-search.netlify.app

@garbas garbas merged commit f624c11 into main Jan 6, 2021
@garbas garbas deleted the turboMaCk/keyboard-navigation branch January 6, 2021 14:58
@garbas garbas mentioned this pull request Jan 6, 2021
Closed
@turboMaCk turboMaCk mentioned this pull request Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr requested changes

@garbas garbas garbas approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search result elements should be keyboard focusable Impossible to Expand Search Results With Keyboard
3 participants
@turboMaCk @samueldr @garbas