Tracking: repeatable treewides

[pbsds]

This is a overview/tracking issue for various easy-to-grep and possibly scriptable janitor treewides, that address mostly benign issues that are prone to slip through review and pile up. Please do link other treewides that fit the bill.

Please don't bog down this issue with by-name migrations, meta.mainProgram additions and with lib removal spam 👍 (unless their creation and testing is fully scripted, enabling full tree coverage and near zero toil)

• nixos/*: tag manpage references #377184
• treewide: migrate fetchgit rev = "refs/tags/..." to tag #368177
• treewide: String escape fixes #365186
• treewide: use stdenv.buildPlatform.canExecute #350195
• treewide: fix typo chown -> chmod #347678
• treewide: fix desktopItems #345778
• treewide: replace passthru.optional-dependencies with optional-dependencies #345232
• treewide: fix editorconfig #341423
• treewide: replace stdenv.is with stdenv.hostPlatform.is #341407
• treewide: remove refs/tags/ from github release meta.changelog urls #338301
• treewide: buildPhase="true" -> dontBuild=true #336743
• treewide: change ${pname} to string literal #336172
• treewide: default.nix -> package.nix in pkgs/by-name #335636
• treewide: remove hardcoded /build #331855
• treewide: use src.name in sourceRoot #331770
• treewide: remove unused fetchpatch (and other) arguments #314635
• treewide: fix urls #310169
• treewide: fix version in changelog #305642
• treewide: use lib.splitVersion #272614
• treewide: remove unreferenced patch files #271362
• treewide: finalAttrs.doCheck -> finalAttrs.finalPackage.doCheck #271241
• treewide: remove execute bit for non-executable *.nix files #262351
• treewide: don't hardcode /nix/store (no rebuilds changes) #222766
• treewide: use hash instead of sha256 #212422
• treewide: replace http by https when https is a permanent redirection #212002
• treewide: set sourceProvenance for packages containing downloaded jars #176278
• treewide: use mirror URLs where available #144825 - with script here
• treewide: run ./maintainers/scripts/update_redirected_urls.sh #105101
• treewide: remove empty buildInputs #69479

Other chores:

• ci: Update pinned Nixpkgs #363585

Feel free to ping me for review :)

[philiptaron]

Thank you for this list, and the clear and kind guidelines that accompany it Peder (@pbsds)!

In the absolute fullness of time, I hope that each of these ends up being in nixpkgs-vet with an autofix mode.

CC @infinisil @willbush.

[pbsds]

I assume this is more in scope for https://github.com/nix-community/nixpkgs-lint?

[patka-123]

This one might be interesting to add to this list?
#347678

[pbsds]

Notes to self

• CI doesn't enumerate number of eval failures introduced by a PR, this either has to be done manually or added to CI
• Use/adapt infinisil/treewide-nixpkgs-reformat-script for other treewides such that they don't interfere with currently open and active PRs

[philiptaron]

#363585 needs to be repeated on some schedule (c.f. #373945)

[pbsds]

#363585 needs to be repeated on some schedule (c.f. #373945)

This strikes me more as a dep-bump chore than treewide janitor work.

Interestingly in this particular case it is not really needed on a regular schedule but rather it should preferably only be triggered whenever for example nixfmt or nixpkgs-review are bumped. Should we create a separate chore-tracking issue, or is this rather a job for automatic GHA actions like the periodic merges from master to staging-next?

[philiptaron]

This strikes me more as a dep-bump chore than treewide janitor work.

It's funny you should say that. To those without the taste to tell the difference, janitorial work is indeed a chore, and the word "repeatable" just emphasizes that. 🙂

I'm happy to follow your lead in whatever organizational scheme makes sense to you, including minimizing these comments and going about other sorts of work in this specific issue.

If action is to be taken, bumping this dependency on (say) a weekly schedule through a GitHub action which opened a PR would make sense to me. We do something like that in nixpkgs-vet:

• https://github.com/NixOS/nixpkgs-vet/blob/main/.github/workflows/update.yml
• https://github.com/NixOS/nixpkgs-vet/blob/main/default.nix#L78-L154

But I currently don't have the stomach for working through the GitHub actions universe to do this for Nixpkgs, so it's just a finger pointing to the horizon at the moment.

[pbsds]

In the meanwhile lets track such here