Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: don't hardcode /nix/store (no rebuilds changes) #222766

Merged
merged 1 commit into from
Mar 25, 2023

Conversation

Artturin
Copy link
Member

improve experience for other store locations

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 23, 2023
@Artturin
Copy link
Member Author

Artturin commented Mar 23, 2023

Unnecessary for this pr but here's a useful command(s)

sudo mkdir -p /test-nix/var/nix && sudo chown --recursive $USER:$USER /test-nix

$(nix build --impure --expr 'with import <nixpkgs> { }; (nix.override { storeDir = "/test-nix/store"; stateDir = "/test-nix/var"; }).out' --no-link --print-out-paths)/bin/nix build ".#bash"

improve experience for other store locations
@Artturin Artturin force-pushed the fix-different-store branch from acb2c00 to 780669d Compare March 24, 2023 18:11
@Artturin
Copy link
Member Author

Thanks @wegank

@Artturin Artturin added the 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform label Mar 25, 2023
@Artturin Artturin marked this pull request as ready for review March 25, 2023 20:15
@Artturin Artturin requested review from IvarWithoutBones and a team as code owners March 25, 2023 20:15
@Artturin Artturin merged commit b213126 into NixOS:master Mar 25, 2023
@Artturin Artturin deleted the fix-different-store branch March 25, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: fetch 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform 6.topic: systemd 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants