Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: run ./maintainers/scripts/update_redirected_urls.sh #374451

Merged
merged 1 commit into from
Jan 17, 2025
Merged

treewide: run ./maintainers/scripts/update_redirected_urls.sh #374451

merged 1 commit into from
Jan 17, 2025

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Jan 17, 2025 •
edited
Loading

repeat of #105101 part of #346453

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds marked this pull request as ready for review January 17, 2025 03:47
@pbsds pbsds requested a review from philiptaron January 17, 2025 03:48
@nix-owners nix-owners bot requested a review from ulrikstrid January 17, 2025 03:49
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 17, 2025
@ulrikstrid
Copy link
Member

Looks good, tried some of the URLs and also made sure the script looked fine

philiptaron
philiptaron approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTPS everywhere!

@philiptaron philiptaron merged commit 05d030a into NixOS:master Jan 17, 2025
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulrikstrid ulrikstrid ulrikstrid approved these changes

@philiptaron philiptaron philiptaron approved these changes

Assignees
No one assigned
Labels
6.topic: lua 6.topic: nodejs 6.topic: ocaml 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbsds @ulrikstrid @philiptaron