-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.incapsula-cracker-py3: init at 0.1.8.1 #117412
pythonPackages.incapsula-cracker-py3: init at 0.1.8.1 #117412
Conversation
Related to #81418 |
--replace "bs4" "beautifulsoup4" | ||
''; | ||
|
||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upstream repo contains tests. Consider to switch to the source provided by GitHub to run the tests.
Add pythonImportsCheck = [ "incapsula" ];
as additional safe-guard.
meta = with lib; { | ||
description = "Bypass sites guarded with Incapsula"; | ||
homepage = "https://github.com/ziplokk1/incapsula-cracker-py3"; | ||
license = licenses.unlicense; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider to add yourself as maintainer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is required for new packages actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of 2 packages built successfully:
2 suggestions:
Result of 2 packages built successfully:
2 suggestions:
|
|
||
prePatch = '' | ||
substituteInPlace setup.py \ | ||
--replace "bs4" "beautifulsoup4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was fixed upstream (ziplokk1/incapsula-cracker-py3#25) in the meantime. But no new release was made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So until it is released, we need this local patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
I marked this as stale due to inactivity. → More info |
Motivation for this change
I'd like to use this library in Python scripts.
@freezeboy Thank you.
https://discourse.nixos.org/t/buildpythonpackage-no-matching-distribution-found-for-requests-from-incapsula-cracker-py3-0-1-8-1/10152/6
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)And in configuration.nix add
sudo nixos-rebuild test -I nixpkgs=/home/forked_repositories/nixpkgs --fast
sudo nixos-rebuild switch -I nixpkgs=/home/forked_repositories/nixpkgs
My python script using this package runs without errors.