Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.incapsula-cracker-py3: init at 0.1.8.1 #117412

Closed
wants to merge 4 commits into from
Closed

pythonPackages.incapsula-cracker-py3: init at 0.1.8.1 #117412

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f718565
pythonPackages.incapsula-cracker-py3: init at 0.1.8.1
Mar 23, 2021
4d762d2
'fix: Checking EditorConfig: Wrong line endings or new final newline'
Mar 23, 2021
f5438fc
'add pythonImportsCheck'
Mar 24, 2021
6329466
Merge branch 'NixOS:master' into pythonPackages.incapsula-cracker-py3
seghers Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions pkgs/development/python-modules/incapsula-cracker-py3/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{ lib, buildPythonPackage, fetchPypi, beautifulsoup4, requests, six }:

buildPythonPackage rec {
pname = "incapsula-cracker-py3";
version = "0.1.8.1";

src = fetchPypi {
inherit pname version;
sha256 = "60079f6602a3e4ef21d68e7bc99b52e378ae1d0e55135b05de01a241d71d1fe7";
};

propagatedBuildInputs = [ beautifulsoup4 requests six ];

prePatch = ''
substituteInPlace setup.py \
--replace "bs4" "beautifulsoup4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed upstream (ziplokk1/incapsula-cracker-py3#25) in the meantime. But no new release was made.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So until it is released, we need this local patch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

'';

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream repo contains tests. Consider to switch to the source provided by GitHub to run the tests.

Add pythonImportsCheck = [ "incapsula" ]; as additional safe-guard.


meta = with lib; {
description = "Bypass sites guarded with Incapsula";
homepage = "https://github.com/ziplokk1/incapsula-cracker-py3";
license = licenses.unlicense;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider to add yourself as maintainer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is required for new packages actually.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed -> https://nixos.org/manual/nixpkgs/unstable/#reviewing-contributions-new-packages

};
}
2 changes: 2 additions & 0 deletions pkgs/top-level/python-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3277,6 +3277,8 @@ in {

imutils = callPackage ../development/python-modules/imutils { };

incapsula-cracker-py3 = callPackage ../development/python-modules/incapsula-cracker-py3 { };

incomfort-client = callPackage ../development/python-modules/incomfort-client { };

incremental = callPackage ../development/python-modules/incremental { };
Expand Down