Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: GCC with separated runtime libraries #132343

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

Conversation

alexfmpe
Copy link
Member

@alexfmpe alexfmpe commented Aug 1, 2021

Motivation for this change

Opening bare bones PR to collaborate on #132340
cc @Ericson2314 @sternenseemann

Things done

All cross compilation from x86_64-unknown-linux-{gnu,musl}. Plug in the config in --crossSystem "{ config = \"$config\"; useGccNg = true; }"

  • buildPackages.gccNgPackages.gcc-unwrapped
    • draft package committed
    • aarch64-unknown-linux-gnu
    • aarch64-unknown-linux-musl
  • gccNgPackages.libgcc
    • draft package committed
    • aarch64-unknown-linux-gnu
    • aarch64-unknown-linux-musl
  • libcCross
    • draft package committed
    • aarch64-unknown-linux-gnu
    • aarch64-unknown-linux-musl
  • gccNgPackages.libatomic
    • draft package committed
    • aarch64-unknown-linux-gnu
    • aarch64-unknown-linux-musl
  • gccNgPackages.libstdcxx
    • draft package committed
    • aarch64-unknown-linux-gnu
    • aarch64-unknown-linux-musl
      • Linking errors due to messed up relocations, evidentally because of mixing -fPIC and -fno-PIC

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.
Upstream patches

Ericson2314 and others added 7 commits August 1, 2021 18:06
Taking a bunch of stuff from 11 packages
* `builtins.attrNames gccNgPackages_11` now evaluates

* Added missing inputs

* Removed a bunch of clang-related things

  - clang-only packages: compiler-rt, libcxx, libcxxabi, openmp

  - useLLVM logic

  - stdenvs / cc-wrappers which are not applicable anymore

* Removed LLVM-specific relics like the default callPackage bindings,
  clean up default callPackage scopes for libraries and tools

* Add runtime libraries (may forgot some) to libraries set
@Ericson2314
Copy link
Member

Ericson2314 commented Aug 6, 2021

Oh no, I forgot to push my stuff! I'll merge. Actually comments won't be too bad.

@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Aug 6, 2021
mkdir -p "$out/lib" "$dev/include"
ln -s "$out/lib/gcc/${stdenv.hostPlatform.config}/${version}"/* "$out/lib"
ln -s "$dev/lib/gcc/${stdenv.hostPlatform.config}/${version}/include"/* "$dev/include/"
'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meta is missing.

@Ericson2314 Ericson2314 added the 6.topic: bootstrap Bootstrapping, avoiding pre-built binaries. Often overlaps with cross-compilation. label Oct 7, 2021
@Mindavi Mindavi mentioned this pull request Oct 13, 2021
8 tasks
@stale
Copy link

stale bot commented Apr 16, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 16, 2022
@alexfmpe
Copy link
Member Author

Unmark stale

@ghost
Copy link

ghost commented Feb 21, 2023

Hi,

It is a bummer that this sort of fell by the wayside. I just wanted to mention that enabling the goals of this PR is one of the major benefits sought by #209870.

Specifically, if that PR merges, my next project will be to start moving the libraries that are bundled with gcc into separate packages -- like this PR, but one at a time, and incrementally rather than in a big rewrite. I would like to reuse as much of the work here as possible.

@Ericson2314
Copy link
Member

https://github.com/Ericson2314/nixpkgs/tree/gcc-ng-12 This was me trying to update this to a new GCC.

@Ericson2314
Copy link
Member

@amjoseph-nixpkgs

#132343 (comment) it is a bummer, and I would love to pair with you on this to get it over the hill at some point. there was just some things I was banging my head against the wall debugging that I need another pair of eyes on.

@infinisil infinisil added the significant Novel ideas, large API changes, notable refactorings, issues with RFC potential, etc. label Oct 31, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-10-31-nixpkgs-architecture-team-meeting-45/34846/1

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: bootstrap Bootstrapping, avoiding pre-built binaries. Often overlaps with cross-compilation. 6.topic: stdenv Standard environment significant Novel ideas, large API changes, notable refactorings, issues with RFC potential, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants