Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.nbconvert: clean up #171735

Merged
merged 5 commits into from
May 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkgs/development/python-modules/jupyter-sphinx/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
, sphinx
, ipywidgets
, pythonOlder
, nbconvert
}:

buildPythonPackage rec {
Expand All @@ -17,7 +18,7 @@ buildPythonPackage rec {
sha256 = "37fc9408385c45326ac79ca0452fbd7ae2bf0e97842d626d2844d4830e30aaf2";
};

propagatedBuildInputs = [ nbformat sphinx ipywidgets ];
propagatedBuildInputs = [ nbconvert nbformat sphinx ipywidgets ];

doCheck = false;

Expand Down
2 changes: 2 additions & 0 deletions pkgs/development/python-modules/jupyter_server/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
, jinja2
, tornado
, pyzmq
, ipykernel
, ipython_genutils
, traitlets
, jupyter_core
Expand Down Expand Up @@ -62,6 +63,7 @@ buildPythonPackage rec {
];

checkInputs = [
ipykernel
pytestCheckHook
pytest-tornasync
requests
Expand Down
65 changes: 30 additions & 35 deletions pkgs/development/python-modules/nbconvert/default.nix
Original file line number Diff line number Diff line change
@@ -1,25 +1,19 @@
{ lib
{ beautifulsoup4
, bleach
, buildPythonPackage
, defusedxml
, fetchPypi
, pytestCheckHook
, glibcLocales
, entrypoints
, bleach
, mistune
, nbclient
, ipywidgets
, jinja2
, pygments
, traitlets
, jupyter_core
, jupyterlab-pygments
, nbformat
, ipykernel
, lib
, markupsafe
, mistune
, nbclient
, pandocfilters
, tornado
, jupyter-client
, defusedxml
, pyppeteer
, pytestCheckHook
, tinycss2
, beautifulsoup4
}:

buildPythonPackage rec {
Expand All @@ -42,37 +36,38 @@ buildPythonPackage rec {
substituteAllInPlace ./nbconvert/exporters/templateexporter.py
'';

checkInputs = [ pytestCheckHook glibcLocales ];

propagatedBuildInputs = [
entrypoints bleach mistune jinja2 pygments traitlets
jupyter_core nbformat ipykernel pandocfilters tornado jupyter-client
defusedxml tinycss2 beautifulsoup4
nbclient
beautifulsoup4
bleach
defusedxml
jinja2
jupyterlab-pygments
markupsafe
mistune
nbclient
pandocfilters
tinycss2
];

# disable preprocessor tests for ipython 7
# see issue https://github.com/jupyter/nbconvert/issues/898
preCheck = ''
export LC_ALL=en_US.UTF-8
HOME=$(mktemp -d)
export HOME=$(mktemp -d)
'';

pytestFlagsArray = [
"--ignore=nbconvert/preprocessors/tests/test_execute.py"
# can't resolve template paths within sandbox
"--ignore=nbconvert/tests/base.py"
"--ignore=nbconvert/tests/test_nbconvertapp.py"
checkInputs = [
ipywidgets
pyppeteer
pytestCheckHook
];

pytestFlagsArray = [
# DeprecationWarning: Support for bleach <5 will be removed in a future version of nbconvert
"-W ignore::DeprecationWarning"
];

disabledTests = [
# Attempts network access (Failed to establish a new connection: [Errno -3] Temporary failure in name resolution)
"test_export"
"test_webpdf_without_chromium"
#"test_cell_tag_output"
#"test_convert_from_stdin"
#"test_convert_full_qualified_name"
"test_webpdf_with_chromium"
];

# Some of the tests use localhost networking.
Expand Down
3 changes: 2 additions & 1 deletion pkgs/development/python-modules/pweave/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
, nbconvert
, markdown
, isPy3k
, ipykernel
}:

buildPythonPackage rec {
Expand All @@ -21,7 +22,7 @@ buildPythonPackage rec {
disabled = !isPy3k;

buildInputs = [ mock pkgs.glibcLocales ];
propagatedBuildInputs = [ matplotlib nbconvert markdown ];
propagatedBuildInputs = [ ipykernel matplotlib nbconvert markdown ];

# fails due to trying to run CSS as test
doCheck = false;
Expand Down
11 changes: 9 additions & 2 deletions pkgs/development/python-modules/widgetsnbextension/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,20 @@
buildPythonPackage rec {
pname = "widgetsnbextension";
version = "3.6.0";
format = "setuptools";

src = fetchPypi {
inherit pname version;
sha256 = "sha256-6Ep6n8ubrz1XEG4YSnOJqPjrk1v3QaXrnWCqGMwCmoA=";
hash = "sha256-6Ep6n8ubrz1XEG4YSnOJqPjrk1v3QaXrnWCqGMwCmoA=";
};

propagatedBuildInputs = [ notebook ];
# setup.py claims to require notebook, but the source doesn't have any imports
# in it.
postPatch = ''
substituteInPlace setup.py --replace "'notebook>=4.4.1'," ""
'';

propagatedBuildInputs = [ ];

# No tests in archive
doCheck = false;
Expand Down