-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.nbconvert: clean up #171735
Conversation
This caused some downstream breakages according to nixpkgs-review. Addressing them now... |
11 packages failed to build: 122 packages built: |
Failures are all pre-existing now. If no one objects I'll go ahead and merge tomorrow. |
Other than Sage, I wonder if there are other packages which depend on |
Yes, IIRC there were some nasty circular dependency issues and this was the cleanest possible solution AFAICT. I guess |
Description of changes
General clean up of the nbconvert derivation. In particular, I found that the set of disabled tests could be made smaller, leading to better test coverage.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes