Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage: depend on python3Packages.notebook #178895

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Conversation

collares
Copy link
Member

Description of changes

sage -n depends on python3Packages.notebook. Previously ipywidgets propagated widgetsnbextension, which propagated notebook, but de16160 changed that.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

Successfully created backport PR #179818 for release-22.05.

@collares
Copy link
Member Author

collares commented Jul 1, 2022

Thanks for merging!

@collares collares deleted the sage-notebook branch July 1, 2022 17:46
@collares collares mentioned this pull request Sep 20, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants