-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qutebrowser: 2.5.4 -> 3.0.0 #250171
qutebrowser: 2.5.4 -> 3.0.0 #250171
Conversation
Result of 2 packages built:
|
@@ -1473,6 +1473,7 @@ mapAliases ({ | |||
quake3game = throw "'quake3game' has been renamed to/replaced by 'ioquake3'"; # Converted to throw 2022-02-22 | |||
quaternion-git = throw "quaternion-git has been removed in favor of the stable version 'quaternion'"; # Added 2020-04-09 | |||
quilter = throw "quilter has been removed from nixpkgs, as it was unmaintained"; # Added 2021-08-03 | |||
qutebrowser-qt6 = throw "'qutebrowser-qt6' has been replaced by 'qutebrowser', since the the qt5 version has been removed"; # Added 2023-08-19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not
qutebrowser-qt6 = throw "'qutebrowser-qt6' has been replaced by 'qutebrowser', since the the qt5 version has been removed"; # Added 2023-08-19 | |
qutebrowser-qt6 = qutebrowser; # Added 2023-08-19 |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed other Qt applications that did a similar migration.
This wasn't just a version bump, you broke A massively drastic change like that shouldn't be smuggled into nixpkgs in a PR which is labeled as a version bump. Prior to this PR the expression supported both |
Description of changes
Version bump
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)