Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qutebrowser: 2.5.4 -> 3.0.0 #251667

Closed
wants to merge 2 commits into from
Closed

qutebrowser: 2.5.4 -> 3.0.0 #251667

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 26, 2023

Description of changes

This is the commit which should have been submitted as #250171.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost requested review from Ericson2314 and matthewbauer as code owners August 26, 2023 20:49
@ghost ghost mentioned this pull request Aug 26, 2023
12 tasks
@github-actions github-actions bot added 6.topic: stdenv Standard environment and removed 6.topic: stdenv Standard environment labels Aug 26, 2023
Adam Joseph added 2 commits August 26, 2023 14:04
This is the commit which should have been submitted as #250171.
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you keeping the version at 2.5.4? 3.0.0 still supports Qt5, despite being advised against. Also QtWebKit is no longer supported and must be removed.

@wegank wegank marked this pull request as draft October 20, 2023 18:33
@ghost ghost closed this Oct 22, 2023
@ghost ghost deleted the pr/qutebrowser/bump branch October 22, 2023 07:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant