rustc: 1.72.1 -> 1.73.0

[alyssais]

Description of changes

This upgrade unfortunately removes MIPS support, as it has been dropped to Tier 3 and so bootstrap tarballs are no longer provided.

It looks like it was dropped due to multiple codegen bugs, and lack of maintenance, so bringing it back would probably involve engaging with Rust/LLVM upstream on those.

• fd on x86_64-darwin
• fd on x86_64-linux
• fd on aarch64-linux
• firefox on x86_64-linux
• thunderbird on x86_64-linux

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[RaitoBezarius]

LGTM.

[alyssais]

Oh, one thing — usually we stick to the same LLVM as Rust upstream, but we don't have LLVM 17 yet (see #258614). IIRC we've been an LLVM behind for Rust before and it hasn't caused any problems.

[workingjubilee]

Oh, one thing — usually we stick to the same LLVM as Rust upstream, but we don't have LLVM 17 yet (see #258614). IIRC we've been an LLVM behind for Rust before and it hasn't caused any problems.

Yes, in the general case we have tried to support using "today's LLVM and yesterday's LLVM" with rustc, with a "maybe" on yesteryear's LLVM. This has been really inconvenient sometimes with certain major LLVM changes like the opaque pointers or pass manager updates, making the results more "fun" for everyone, both compiler engineers and distro maintainers, but it seems nothing earthshattering is in LLVM 17, by comparison.

This is also part of why it's undesirable to have a mostly-unmaintained target being advertised as tier 2: even if all the codegen problems got patches in flight right now, they might not see a release until LLVM 18, depending on LLVM's patch cycle. So we'd only be confident we wouldn't get reports for them after we updated to LLVM 19 and then dropped LLVM 17.

[figsoda]

tried testing on darwin, but the build box kept running out of disk space, lgtm on linux

[evanrichter]

tried testing on darwin, but the build box kept running out of disk space, lgtm on linux

works for me on my aarch64-darwin host

[ghost]

This upgrade unfortunately removes MIPS support, as it has been dropped to Tier 3 and so bootstrap tarballs are no longer provided.

😭

[ghost]

Heads up, this bump breaks cross compilation of crate2nix-driven projects in a very weird way:

• rustc 1.73 breaks crate2nix cross compilation nix-community/crate2nix#313

If you use crate2nix to cross compile you might need to stick to 1.72.1 until we figure out what went wrong here.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-get-latest-cargo-version/35406/2