trust-dns: rebrand as hickory-dns #262268
Conversation
oneingan
force-pushed
the
rebrand-trust-dns
branch
from
bc789b3
to
2449e7d
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2784 |
oneingan
force-pushed
the
rebrand-trust-dns
branch
from
2449e7d
to
80f58e5
Compare
oneingan
force-pushed
the
rebrand-trust-dns
branch
from
80f58e5
to
30e7ecd
Compare
| serviceConfig = { | ||
| ExecStart = | ||
| let | ||
| flags = (lib.optional cfg.debug "--debug") ++ (lib.optional cfg.quiet "--quiet"); | ||
| flagsStr = builtins.concatStringsSep " " flags; | ||
| in '' | ||
| ${cfg.package}/bin/trust-dns --config ${configFile} ${flagsStr} | ||
| ${cfg.package}/bin/hickory-dns --config ${configFile} ${flagsStr} |
There was a problem hiding this comment.
without bumping the package version, this change doesn't work. 0.23.0 still ships only bin/trust-dns and not bin/hickory-dns. and 0.24.0 ships bin/hickory-dns only, without bin/trust-dns. so unless we want to introduce and leverage meta.mainProgram, there has to be a patch which simultaneously upgrades 0.23.0 -> 0.24.0 and changes the name here.
There was a problem hiding this comment.
here's a PR which, if merged before the rebrand, would address this issue: #263054
There was a problem hiding this comment.
PR above has been merged, should be safe to just leave this line as it's set in master
|
@oneingan if you get a chance to rebase this patch, it should be good to go. i can give it a deploy and then sign off. |
|
@oneingan can you please rebase the PR? |
|
Apologies for the wait. The situation is that initially, we intended to implement trust-dns in our company, but we opted for a different solution. If you're still comfortable with it, I can attempt to merge this, but please note that I may not be able to provide ongoing maintenance for it. |
i'm committed to maintaining trust-dns/hickory-dns for the indefinite future, so no problem there. if you're still using trust-dns in a more limited context or otherwise want to provide review/testing on future package updates, that's more than okay, otherwise just remove your name from |
|
would be nice to have this merged, if there isn't much blocking it |
Description of changes
Trust DNS project has been recently rebranded to Hickory DNS. This blog post explains the reasoning behind this move.
I have staged more changes to Hickory DNS package and NixOS Module but prefer for this PR only cover the rebranding stuff.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)