trust-dns: 0.23.0 -> 0.24.0 #263054
Merged
trust-dns: 0.23.0 -> 0.24.0 #263054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
This was referenced Oct 24, 2023
ofborg
bot
added
11.by: package-maintainer
upstream is in the process of renaming to `hickory-dns`. a consequence of this is that the main binary has been renamed from `trust-dns` to `hickory-dns` and the repository has been moved (though for the time being the old repo is still usable on account that it redirects to the new one). see: <https://bluejekyll.github.io/blog/posts/announcing-hickory-dns/>
uninsane
force-pushed
the
pr-trust-dns-0.24.0
branch
from
cb13904
to
83bf3ed
Compare
|
Result of 2 packages blacklisted:
1 package built:
|
Stunkymonkey
approved these changes
Nov 7, 2023
Stunkymonkey
added
the
12.approvals: 1
| @@ -135,7 +135,7 @@ in | |||
| flags = (lib.optional cfg.debug "--debug") ++ (lib.optional cfg.quiet "--quiet"); | |||
| flagsStr = builtins.concatStringsSep " " flags; | |||
| in '' | |||
| ${cfg.package}/bin/trust-dns --config ${configFile} ${flagsStr} | |||
| ${cfg.package}/bin/${cfg.package.meta.mainProgram} --config ${configFile} ${flagsStr} | |||
There was a problem hiding this comment.
This could be simplifed to just use lib.getExe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upstream is in the process of renaming to
hickory-dns. a consequence of this is that the main binary has been renamed fromtrust-dnstohickory-dns. see: https://bluejekyll.github.io/blog/posts/announcing-hickory-dns/broader nixpkgs work for the rename (i.e. renaming the service and publishing release notes) is implemented in this outstanding PR.
changelog: https://github.com/bluejekyll/trust-dns/releases/tag/v0.24.0
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)