Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cosmic-settings: init at unstable-2023-10-26 #264206

Merged
merged 1 commit into from
Nov 2, 2023
Merged

cosmic-settings: init at unstable-2023-10-26 #264206

merged 1 commit into from
Nov 2, 2023

Conversation

nyabinary
Copy link
Contributor

@nyabinary nyabinary commented Oct 29, 2023 •
edited
Loading

Description of changes

Depends on #264225

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nyabinary nyabinary force-pushed the cosmic-settings branch 2 times, most recently from a30e0e0 to 98c120e Compare October 29, 2023 17:58
@alyssais alyssais self-requested a review October 31, 2023 14:56
@nyabinary nyabinary marked this pull request as ready for review October 31, 2023 16:30
@alyssais alyssais merged commit 02ee793 into NixOS:master Nov 2, 2023
29 checks passed
@nyabinary nyabinary mentioned this pull request Nov 2, 2023
Open
30 tasks
@nyabinary nyabinary deleted the cosmic-settings branch November 2, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyabinary @alyssais @delroth