Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cosmic-icons: init at unstable-2023-08-30 #264225

Merged
merged 1 commit into from
Nov 1, 2023
Merged

cosmic-icons: init at unstable-2023-08-30 #264225

merged 1 commit into from
Nov 1, 2023

Conversation

a-kenji
Copy link
Contributor

@a-kenji a-kenji commented Oct 29, 2023 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nyabinary nyabinary mentioned this pull request Oct 29, 2023
Merged
13 tasks
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 29, 2023
@natsukium
Copy link
Member

@ofborg eval

K900
K900 reviewed Oct 31, 2023
View reviewed changes
pkgs/by-name/co/cosmic-icons/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-icons/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-icons/package.nix Show resolved Hide resolved
@alyssais alyssais self-requested a review October 31, 2023 14:56
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 31, 2023
@nyabinary nyabinary self-requested a review November 1, 2023 18:10
nyabinary
nyabinary approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@nyabinary nyabinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 1, 2023
@alyssais alyssais merged commit da939a8 into NixOS:master Nov 1, 2023
23 of 24 checks passed
@a-kenji a-kenji deleted the init/cosmic-icons branch November 1, 2023 19:09
@a-kenji
Copy link
Contributor Author

a-kenji commented Nov 1, 2023

Thanks for the help and reviews!

@nyabinary nyabinary mentioned this pull request Nov 2, 2023
Open
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K900 K900 K900 left review comments

@nyabinary nyabinary nyabinary approved these changes

@alyssais alyssais alyssais approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@a-kenji @natsukium @K900 @alyssais @nyabinary @delroth