Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powerdns-admin: fix build #264232

Merged
merged 4 commits into from
Dec 3, 2023
Merged

powerdns-admin: fix build #264232

merged 4 commits into from
Dec 3, 2023

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Oct 29, 2023

Description of changes

Fix the build of flask-seasurf and powerdns-admin.
Things got broken by the last flask and werkzeug update.

powerdns-admin.tests succeed with these fixes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium
Copy link
Member

@ofborg eval

@pbsds pbsds added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 16, 2023
@pbsds
Copy link
Member

pbsds commented Nov 16, 2023

@Flakebi
Copy link
Member Author

Flakebi commented Dec 2, 2023

Finally got around to update this PR. Now using patch files instead of search-and-replace (see the two new commits).
I tried again, but it seems like flask-seasurf does not support pytest.

@pbsds
Copy link
Member

pbsds commented Dec 3, 2023

@ofborg eval

@pbsds pbsds merged commit f916cbf into NixOS:master Dec 3, 2023
11 checks passed
Copy link
Contributor

github-actions bot commented Dec 3, 2023

Successfully created backport PR for release-23.11:

@Flakebi Flakebi deleted the powerdns-admin branch December 4, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants