Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powerdns-admin: unbreak by downgrading deps #265116

Closed
wants to merge 1 commit into from

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Nov 3, 2023

Description of changes

This PR marks flask-seasurf as unbroken, to not get issues with #265096 once both are merged

The hydra job shows no issue due to a transitive build failiure.
Once the attempted fix in #265096 is applied, then it is revealed that this package is also broken.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@pbsds pbsds marked this pull request as ready for review November 3, 2023 00:20
@pbsds pbsds force-pushed the fix-powerdns-admin-1698968477 branch from eff6894 to 36a3774 Compare November 3, 2023 00:25
@pbsds pbsds force-pushed the fix-powerdns-admin-1698968477 branch from 36a3774 to c321b54 Compare November 3, 2023 11:07
@ofborg ofborg bot requested review from Flakebi and zhaofengli November 3, 2023 11:35
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 3, 2023
@Flakebi
Copy link
Member

Flakebi commented Nov 3, 2023

There’s a build fix for powerdns-admin and flask-seasurf in #264232

@pbsds pbsds closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants