ncurses: fix splicing #265060
ncurses: fix splicing #265060
Conversation
| @@ -48,20 +48,17 @@ stdenv.mkDerivation (finalAttrs: { | |||
| "/usr/share/terminfo" # upstream default, probably all FHS-based distros | |||
| "/run/current-system/sw/share/terminfo" # NixOS | |||
| ]}" | |||
| ]; | |||
| ] ++ lib.optional (stdenv.buildPlatform != stdenv.hostPlatform) "--with-build-cc=${stdenv.cc.targetPrefix}cc"; | |||
There was a problem hiding this comment.
Wouldn't this be the host C compiler? The build compiler would be just cc. (Or is this a terminology mismatch between Nixpkgs and ncurses?)
There was a problem hiding this comment.
It's definitely confusing. See https://github.com/mirror/ncurses/blob/master/INSTALL#L2421.
Without this change the internal tools don't build. I actually had it set to cc and it failed during configure.
There was a problem hiding this comment.
Could maybe use a comment then.
There was a problem hiding this comment.
actually had it set to cc and it failed during configure
because there's no cc unless the for build cc is in depsBuildBuild, I doubt this works as it is now.
There was a problem hiding this comment.
and indeed pkgsCross.aarch64-multiplatform.ncurses fails
ncurses-aarch64-unknown-linux-gnu> checking if the build-compiler "aarch64-unknown-linux-gnu-cc" works... no
There was a problem hiding this comment.
I pulled that out of depsBuildBuild to get rid of the mismatch warning so I'm not sure what the fix would be.
There was a problem hiding this comment.
and indeed
pkgsCross.aarch64-multiplatform.ncursesfailsncurses-aarch64-unknown-linux-gnu> checking if the build-compiler "aarch64-unknown-linux-gnu-cc" works... no
@Artturin: with this PR I get checking if the build-compiler "aarch64-unknown-linux-gnu-cc" works... yes and it successfully cross compiles.
There was a problem hiding this comment.
Oh! My nixos install had binfmt enabled and that's why it succeeded for me.
|
Changed to target |
kjeremy
force-pushed
the
ncurses-fix-cross
branch
from
dbca014
to
40a4ad2
Compare
kjeremy
added
the
6.topic: cross-compilation
…ckages.cryptolyzer python310Packages.cryptolyzer: 0.10.0 -> 0.10.3
…ckages.cryptoparser python310Packages.cryptoparser: 0.10.3 -> 0.11.0
The PAM service `greetd` creates now autostarts GNOME Keyring when it is enabled via `services.gnome.gnome-keyring.enable`. Should cause a lot fewer headaches for people like me who didn't know why GNOME Keyring was complaining that it was never supplied with login details. Fixes NixOS#246197
- disable on unsupported Python releases
docker-slim: 1.40.4 -> 1.40.5
…2JitPackages.plpgsql_check postgresql12JitPackages.plpgsql_check: 2.5.4 -> 2.6.0
gallery-dl: 1.26.1 -> 1.26.2
nerdctl: 1.6.2 -> 1.7.0
decker: 1.31 -> 1.32
procs: 0.14.0 -> 0.14.3
kjeremy
requested review from
mweinelt,
thoughtpolice,
marsam,
ttuegel,
edwtjo,
FRidh,
a team,
dasJ,
Ericson2314,
edolstra and
infinisil
as code owners
github-actions
bot
added
6.topic: python
6.topic: nixos
6.topic: qt/kde
6.topic: kernel
8.has: module (update)
6.topic: emacs
6.topic: printing
6.topic: vim
6.topic: ocaml
6.topic: fetch
6.topic: steam
6.topic: lua
6.topic: systemd
6.topic: vscode
6.topic: lib
|
oops |
Fixes warnings with #263082 applied
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)