Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncurses: fix splicing #265891

Merged
merged 1 commit into from
Nov 8, 2023
Merged

ncurses: fix splicing #265891

merged 1 commit into from
Nov 8, 2023

Conversation

kjeremy
Copy link
Contributor

@kjeremy kjeremy commented Nov 6, 2023

Fixes warnings with #263082 applied

Description of changes

It's #265060 but not messed up.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Fixes warnings with NixOS#263082 applied

Update pkgs/development/libraries/ncurses/default.nix

Co-authored-by: Artturi <Artturin@artturin.com>

ncurses: Explicitly use buildPackages for --with-build-cc

stdenv.cc worked for me because my nixos was configured to use boot.binfmt.emulatedSystems.
@kjeremy kjeremy requested a review from a user November 6, 2023 18:26
@kjeremy kjeremy added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Nov 6, 2023
@ghost ghost mentioned this pull request Nov 7, 2023
12 tasks
@Artturin Artturin merged commit b771463 into NixOS:staging Nov 8, 2023
27 of 28 checks passed
@kjeremy kjeremy deleted the ncurses-fix-cross2 branch November 8, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants