Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-updates] python3Packages.gradio-client: 0.5.0 -> 0.7.3 #274322

Merged
merged 13 commits into from
Dec 17, 2023

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Dec 14, 2023

Description of changes

context: #273538 (comment)

Can't test due to an eval error.

@mweinelt: do you prefer PRs or is it more normal/preferred to push directly to python-updates?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds marked this pull request as ready for review December 14, 2023 23:22
@mweinelt
Copy link
Member

google-cloud-cpp = disable-warnings-if-gcc13 (callPackage ../development/libraries/google-cloud-cpp { });

This is due to disable-warninigs-if-gcc13 settings env.NIX_CFLAGS_COMPILE, as well as the derivation itself. #268097 (comment)

do you prefer PRs or is it more normal/preferred to push directly to python-updates?

If you are confident about the change, you can push it there.

The patch is merged in 2.16.0, but bumping is not
trivial and my machine takes 1h12m57s to build this.
@pbsds
Copy link
Member Author

pbsds commented Dec 16, 2023

@mweinelt gradio now builds with all the fixes added. Feel free to merge or rebase as you see fit

I ended up cherry-picking a bump from #273538, i assume it won't cause a merge conflict

@mweinelt mweinelt merged commit b1246bc into NixOS:python-updates Dec 17, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants