-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cataclysm-dda: fix gcc 13 build with 3 debian patches. #282444
Conversation
Instead of disabling warnings, can we apply patches from Debian or from upstream? |
Yes, adding 3 patches to pkgs/games/cataclysm-dda/stable.nix fixes the build as well. Would you mind telling me if fetchpatch is the best way to apply these or if I should use something else?
|
Using |
Added those 3 patches to the stable.nix and git.nix files in the cataclysm-dda folder. Both build now. Let me know if there's anything else needed. |
Looks like upstream has these fixed in the master branch as well (independent of the Debian patches): Haven't checked if they apply cleanly, so the Debian patches might be preferable here. Would be a good idea to include a comment that says something like "Fixes for failing build with GCC13, remove on updating to next release after 0.G" |
Thanks, looks good, but please squash everything down to one commit with an appropriate commit message. |
Release 0.G needs 3 patches to build successfully with gcc 13. These can be removed after the next release. [patch] disable dangling reference warning [patch] fix build with gcc 13 [patch] cleanup autogenerated prefix.h
Sounds good. Should be good to go. |
@ofborg build cataclysm-dda cataclysm-dda.passthru.tests |
Description of changes
Edit:
Fixed failing gcc 13 build with 3 patches from Debian.
[patch] disable dangling reference warning
[patch] fix build with gcc 13
[patch] cleanup autogenerated prefix.h
Fixed build failures for cataclysm-dda and cataclysm-dda-git by usingdisable-warnings-if-gcc13
(see #268097).Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.