Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin.moltenvk: 1.2.4 -> 1.2.7 #284256

Merged
merged 4 commits into from
Jan 30, 2024
Merged

darwin.moltenvk: 1.2.4 -> 1.2.7 #284256

merged 4 commits into from
Jan 30, 2024

Conversation

wegank
Copy link
Member

@wegank wegank commented Jan 27, 2024 •
edited
Loading

Description of changes

https://github.com/KhronosGroup/MoltenVK/releases/tag/v1.2.7

Vulkan SDK is already at 1.3.275 on master, and darwin.moltenvk is broken there (#284281).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 27, 2024
@ofborg ofborg bot requested a review from reckenrode January 27, 2024 14:09
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 27, 2024
@wegank wegank mentioned this pull request Jan 27, 2024
Merged
13 tasks
@wegank wegank marked this pull request as ready for review January 27, 2024 15:50
@wegank wegank marked this pull request as draft January 27, 2024 15:51
@wegank wegank marked this pull request as ready for review January 27, 2024 15:53
@khaneliman khaneliman mentioned this pull request Jan 27, 2024
Closed
@khaneliman
Copy link
Contributor

Result of nixpkgs-review pr 284256 run on aarch64-darwin 1

62 packages marked as broken and skipped:
  • airshipper
  • ajour
  • anilibria-winmaclinux
  • arcan
  • colloid-kde
  • colloid-kde.sddm
  • dwl
  • dwl.man
  • flycast
  • graphite-kde-theme
  • grimblast
  • hyprpicker
  • kaffeine
  • kphotoalbum
  • labwc
  • labwc.man
  • latte-dock
  • layan-kde
  • libsForQt5.bismuth
  • libsForQt5.krohnkite
  • libsForQt5.kwin-dynamic-workspaces
  • libsForQt5.kwin-tiling
  • libsForQt5.kzones
  • libsForQt5.parachute
  • lightly-boehs
  • lightly-qt
  • ludusavi
  • mesa-demos
  • mojave-gtk-theme
  • nordic
  • nordic.sddm
  • plasma5Packages.bismuth
  • plasma5Packages.krohnkite
  • plasma5Packages.kwin-dynamic-workspaces
  • plasma5Packages.kwin-tiling
  • plasma5Packages.kzones
  • plasma5Packages.parachute
  • python311Packages.py3status
  • python311Packages.py3status.dist
  • python311Packages.python-vlc
  • python311Packages.python-vlc.dist
  • python311Packages.qtile-extras
  • python311Packages.qtile-extras.dist
  • python312Packages.python-vlc
  • python312Packages.python-vlc.dist
  • qogir-kde
  • rivercarro
  • shairport-sync
  • snapshot
  • utterly-nord-plasma
  • vimix-gtk-themes
  • vulkan-caps-viewer
  • waybox
  • wayfire
  • wayfirePlugins.wayfire-plugins-extra
  • wayfirePlugins.wcm
  • wayfirePlugins.wf-shell
  • wayfirePlugins.windecor
  • whitesur-gtk-theme
  • whitesur-kde
  • wio
  • xarcan
8 packages failed to build:
  • gfxstream
  • halloy
  • libplacebo
  • ncnn
  • realesrgan-ncnn-vulkan
  • rutabaga_gfx
  • vkquake
  • vulkan-tools
10 packages built:
  • darwin.moltenvk
  • darwin.moltenvk.bin
  • darwin.moltenvk.dev
  • dolphin-emu
  • fastfetch
  • libplacebo_5
  • rbdoom-3-bfg
  • vulkan-loader
  • vulkan-loader.dev
  • wgpu-utils

@ofborg ofborg bot requested a review from Ralith January 27, 2024 16:49
@wegank wegank mentioned this pull request Jan 27, 2024
Closed
13 tasks
@ofborg ofborg bot requested a review from ylh January 27, 2024 17:18
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jan 27, 2024
@ofborg ofborg bot requested review from primeos and tadeokondrak January 27, 2024 17:26
@ofborg ofborg bot added 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 27, 2024
Ralith
Ralith approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not equipped to test this, but it looks reasonable.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 27, 2024
@khaneliman
Copy link
Contributor

Result of nixpkgs-review pr 284256 run on aarch64-darwin 1

62 packages marked as broken and skipped:
  • airshipper
  • ajour
  • anilibria-winmaclinux
  • arcan
  • colloid-kde
  • colloid-kde.sddm
  • dwl
  • dwl.man
  • flycast
  • graphite-kde-theme
  • grimblast
  • hyprpicker
  • kaffeine
  • kphotoalbum
  • labwc
  • labwc.man
  • latte-dock
  • layan-kde
  • libsForQt5.bismuth
  • libsForQt5.krohnkite
  • libsForQt5.kwin-dynamic-workspaces
  • libsForQt5.kwin-tiling
  • libsForQt5.kzones
  • libsForQt5.parachute
  • lightly-boehs
  • lightly-qt
  • ludusavi
  • mesa-demos
  • mojave-gtk-theme
  • nordic
  • nordic.sddm
  • plasma5Packages.bismuth
  • plasma5Packages.krohnkite
  • plasma5Packages.kwin-dynamic-workspaces
  • plasma5Packages.kwin-tiling
  • plasma5Packages.kzones
  • plasma5Packages.parachute
  • python311Packages.py3status
  • python311Packages.py3status.dist
  • python311Packages.python-vlc
  • python311Packages.python-vlc.dist
  • python311Packages.qtile-extras
  • python311Packages.qtile-extras.dist
  • python312Packages.python-vlc
  • python312Packages.python-vlc.dist
  • qogir-kde
  • rivercarro
  • shairport-sync
  • snapshot
  • utterly-nord-plasma
  • vimix-gtk-themes
  • vulkan-caps-viewer
  • waybox
  • wayfire
  • wayfirePlugins.wayfire-plugins-extra
  • wayfirePlugins.wcm
  • wayfirePlugins.wf-shell
  • wayfirePlugins.windecor
  • whitesur-gtk-theme
  • whitesur-kde
  • wio
  • xarcan
5 packages failed to build:
  • gfxstream
  • halloy
  • ncnn
  • realesrgan-ncnn-vulkan
  • rutabaga_gfx
14 packages built:
  • darwin.moltenvk
  • darwin.moltenvk.bin
  • darwin.moltenvk.dev
  • dolphin-emu
  • fast-float
  • fastfetch
  • libplacebo
  • libplacebo_5
  • rbdoom-3-bfg
  • vkquake
  • vulkan-loader
  • vulkan-loader.dev
  • vulkan-tools
  • wgpu-utils

@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 27, 2024
@reckenrode
Copy link
Contributor

Thanks for taking care of this. I apologize for not taking care of fixing the build earlier. I was expecting the Xcode project changes to be worse than they turned out to be. Aside for the one question regarding vulkan-tools, LGTM.

@delroth delroth removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 28, 2024
@ofborg ofborg bot requested review from Ralith and reckenrode January 28, 2024 05:04
@davidkna davidkna mentioned this pull request Jan 30, 2024
Merged
13 tasks
@wegank wegank merged commit a940bf9 into NixOS:master Jan 30, 2024
24 checks passed
@wegank wegank deleted the moltenvk-bump branch January 30, 2024 12:20
@t-monaghan t-monaghan mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaneliman khaneliman khaneliman approved these changes

@ylh ylh Awaiting requested review from ylh

@primeos primeos Awaiting requested review from primeos

@tadeokondrak tadeokondrak Awaiting requested review from tadeokondrak

@Ralith Ralith Awaiting requested review from Ralith

@reckenrode reckenrode Awaiting requested review from reckenrode

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wegank @khaneliman @reckenrode @Ralith @delroth