Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast-float: init at 6.0.0 #284302

Closed
wants to merge 2 commits into from
Closed

fast-float: init at 6.0.0 #284302

wants to merge 2 commits into from

Conversation

wegank
Copy link
Member

@wegank wegank commented Jan 27, 2024

Description of changes

Split from #284256.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 27, 2024
@raspher
Copy link
Member

raspher commented Jan 28, 2024

Result of nixpkgs-review pr 284302 run on aarch64-linux 1

1 package built:
  • fast-float

@wegank
Copy link
Member Author

wegank commented Jan 31, 2024

Done in #284256.

@wegank wegank closed this Jan 31, 2024
@wegank wegank deleted the fast-float-init branch January 31, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants