-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duckstation: 0.1-6292 -> 0.1-6658 #309064
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3878 |
Result of 1 package built:
Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Result of 1 package built:
|
d6536b4
to
4e77df2
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1618 |
4e77df2
to
9b5cb75
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
9b5cb75
to
7cc72bc
Compare
2c8e338
to
55c36d7
Compare
a67d9f0
to
0becf0c
Compare
CI error:
|
Where? |
0becf0c
to
e91363c
Compare
Now it should work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm beginning to lose patience due to your insistence on enlarging the diff for no real good reason. I wanted to spare us the review-change ping pong, by rebasing your branch myself, but you are not allowing maintainers to edit the PR .
Your next trial is your last.
e91363c
to
b3a236c
Compare
Anything else? |
b3a236c
to
7b3e297
Compare
I am on that web interface of GitHub, and the "allow edits by maintainers" checkbox does not exist. I have opened another PR right now and can confirm: there is no checkbox. |
Oh, anything else? [2] |
https://github.com/orgs/community/discussions/5634
|
@SuperSandro2000 and @doronbehar Your both reviews are mutually incompatible. Bringing back qt6.callPackage is not compatible to get rid of all-packages.nix. I am unable to satisfy both of your reviews at the same time. Please solve this between yourselves before I can take any action (besides rebasing this over Master Branch). |
And just for venting a decade-old frustration, |
Since by-name hierarchy does not support "third party" callPackage calls, the expression was modified to get rid of qt6Packages.
Duckstation now uses a vendored shaderc. However, this vendoring is provided by a patch.
7b3e297
to
9b1c668
Compare
For easily finding it, a discussion is happening in this thread.
It's only for a small subset of files for now, people are very eager to use the standard formatter already :). For reference, #299578 introduced it, also #313628 is relevant. Also see #322520. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test properly running this in a game, but builds and starts fine.
splicing works without qt6.callPackage
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/frustrations-about-splicing/49607/1 |
Description of changes
Closes #308974 (by assimilation)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.