Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
superfly/flyctl@v0.2.69...v0.2.71
buildGoDir
internally tacks on the tags and other flags we define. Forflyctl
, this results in a panic in an upstream dependency (specifically, whentags
includeproduction
, flyctl attempts to report errors to sentry with a insufficiently initialized HTTP transport, resulting in a panic within sentry-go)There are two upstream issues filed which should resolve this and allow us to go back to using
buildGoDir
:superfly/flyctl#3642 - With an accompanying PR superfly/flyctl#3643
getsentry/sentry-go#841
Closes #320658.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.