bugfix: build upon default sentry-go transport config #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Directly initializing the NewHTTPSyncTransport struct results in the non-exported limits map being nil, which can cause a panic in sentry-go under certain conditions
RaghavSood
force-pushed
the
sentry-go/init-fix
branch
from
add6983
to
1fbffa9
Compare
|
thanks @RaghavSood ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly initializing the HTTPSyncTransport struct results in the non-exported limits map being nil, which can cause a panic in sentry-go under certain conditions
Change Summary
Fixes: #3642
What and Why: By setting the timeout on the default
HTTPSyncTransportreturned byNewHTTPSyncTransport, we avoid a panic within the sentry-go SDKHow:
Related to:
Documentation