Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evil-helix: init at 20240618 #324544

Merged
merged 1 commit into from
Jul 4, 2024
Merged

evil-helix: init at 20240618 #324544

merged 1 commit into from
Jul 4, 2024

Conversation

thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Jul 4, 2024 •
edited
Loading

Description of changes

Soft fork of Helix Editor, with vim keybindings: https://github.com/usagi-flow/evil-helix.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

AndersonTorres
AndersonTorres reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fork because of ESC hjkl? o.Õ

pkgs/by-name/ev/evil-helix/package.nix Outdated Show resolved Hide resolved
@thiagokokada
Copy link
Contributor Author

thiagokokada commented Jul 4, 2024 •
edited
Loading

A fork because of ESC hjkl? o.Õ

No, the main reason is because Helix follows Kakoune with its selection -> verb, while Vim uses the opposite (verb -> selection). So instead of Vim's cw, you use wc (for example, I am not completely sure actually). This messes up your muscle memory a lot.

This project basically changes it, but it is a Work-in-Progress (some things doesn't work as expect, for example V does not work for vertical selection).

See for more information: usagi-flow/evil-helix#11. This also shows why it is not possible to just change some keybindings in the config.toml file.

@lucasew
Copy link
Contributor

lucasew commented Jul 4, 2024

Result of nixpkgs-review pr 324544 run on x86_64-linux 1

1 package built:
  • evil-helix

@thiagokokada thiagokokada merged commit 14b0861 into NixOS:master Jul 4, 2024
36 of 38 checks passed
@thiagokokada thiagokokada deleted the evil-helix-init branch July 4, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thiagokokada @lucasew @AndersonTorres