python312Packages.xlib: disable tests for python 3.12 #325676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 9, 2024
StarGate01
force-pushed
the
fix-xlib
branch
2 times, most recently
from
799862e
to
0d78821
Compare
StarGate01
changed the title
|
Thanks for the heads-up @natsukium , I have modified the PR as you suggested. Also did the same to #325680 . |
fpletz
approved these changes
Jul 9, 2024
13 tasks
|
Oh yeah, sorry. 🤦 |
1 task
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Since the default Python version was upgraded from
3.11to3.12, some packges broke which depend on Python packages not compatible with3.12.xlibrequiresnose, which does not support3.12. The alternativepynose(https://pypi.org/project/pynose/) does support3.12, and does the same job.This fixes the build of
neofetch(viaueberzug) .Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.