Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.jaconv: disable tests for python 3.12 #325680

Merged
merged 1 commit into from
Jul 9, 2024
Merged

python312Packages.jaconv: disable tests for python 3.12 #325680

merged 1 commit into from
Jul 9, 2024

Conversation

StarGate01
Copy link
Member

@StarGate01 StarGate01 commented Jul 9, 2024 •
edited
Loading

Description of changes

Fixes #325657 .

For details, see #325676 . This PR does the same replacement of nose to pynose .

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@StarGate01 StarGate01 requested a review from fabaff July 9, 2024 00:18
natsukium
natsukium previously requested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pynose violates the license and will be removed. #325669
If you need nose for testing, please disable tests in 3.12.

@StarGate01 StarGate01 changed the title python312Packages.jaconv: replace nose with pynose python312Packages.jaconv: disable tests for python 3.12 Jul 9, 2024
@StarGate01 StarGate01 requested a review from natsukium July 9, 2024 02:50
@StarGate01 StarGate01 mentioned this pull request Jul 9, 2024
Merged
13 tasks
@fpletz fpletz dismissed natsukium’s stale review July 9, 2024 13:30

Tests now disabled for Python 3.12

@fpletz fpletz merged commit 2c5c530 into NixOS:master Jul 9, 2024
26 of 28 checks passed
@dotlambda dotlambda mentioned this pull request Jul 9, 2024
Merged
13 tasks
@D3vil0p3r D3vil0p3r added the backport release-24.05 Backport PR automatically label Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Jul 9, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@fabaff fabaff Awaiting requested review from fabaff

@natsukium natsukium Awaiting requested review from natsukium

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure with nose python 3.12
4 participants
@StarGate01 @fpletz @natsukium @D3vil0p3r