python312Packages.pycdio: drop nose dependency #330695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansol
reviewed
Jul 28, 2024
emilazy
requested changes
Jul 28, 2024
emilazy
reviewed
Jul 29, 2024
|
Btw this would fix this issue: #331094 |
emilazy
requested changes
Aug 10, 2024
Comment on lines
54
to
48
| pytestFlagsArray = [ | ||
| "test/test-cdio.py" | ||
| "test/test-cdtext.py" | ||
| "test/test-iso.py" | ||
| "test/test-isocopy.py" | ||
| ]; |
There was a problem hiding this comment.
Can’t this just be "test" (or "test/")?
There was a problem hiding this comment.
Probably, we can't. The upstream uses - instead of _.
https://docs.pytest.org/en/7.1.x/explanation/goodpractices.html#conventions-for-python-test-discovery
There was a problem hiding this comment.
This works and would be more robust to future additions of tests:
Suggested change
| pytestFlagsArray = [ | |
| "test/test-cdio.py" | |
| "test/test-cdtext.py" | |
| "test/test-iso.py" | |
| "test/test-isocopy.py" | |
| ]; | |
| pytestFlagsArray = [ "test/test-*.py" ]; |
|
GitHub is hiding my additional comment: the |
|
Change sources to the GitHub repo andadopted the package Sadly tests are indeed not found when setting |
emilazy
requested changes
Aug 10, 2024
Comment on lines
54
to
48
| pytestFlagsArray = [ | ||
| "test/test-cdio.py" | ||
| "test/test-cdtext.py" | ||
| "test/test-iso.py" | ||
| "test/test-isocopy.py" | ||
| ]; |
There was a problem hiding this comment.
This works and would be more robust to future additions of tests:
Suggested change
| pytestFlagsArray = [ | |
| "test/test-cdio.py" | |
| "test/test-cdtext.py" | |
| "test/test-iso.py" | |
| "test/test-isocopy.py" | |
| ]; | |
| pytestFlagsArray = [ "test/test-*.py" ]; |
natsukium
approved these changes
Aug 11, 2024
emilazy
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.