Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.pycdio: drop nose dependency #330695

Merged
merged 1 commit into from
Aug 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 29 additions & 31 deletions pkgs/development/python-modules/pycdio/default.nix
Original file line number Diff line number Diff line change
@@ -1,54 +1,52 @@
{
lib,
stdenv,
buildPythonPackage,
fetchPypi,
fetchFromGitHub,
setuptools,
nose,
pkgs,
pkg-config,
swig,
libcdio,
libiconv,
pytestCheckHook,
}:

buildPythonPackage rec {
pname = "pycdio";
version = "2.1.1";
format = "setuptools";
version = "2.1.1-unstable-2024-02-26";
pyproject = true;

src = fetchPypi {
inherit pname version;
sha256 = "61734db8c554b7b1a2cb2da2e2c15d3f9f5973a57cfb06f8854c38029004a9f8";
src = fetchFromGitHub {
owner = "rocky";
repo = "pycdio";
rev = "806c6a2eeeeb546055ce2ac9a0ae6a14ea53ae35"; # no tag for this version (yet)
hash = "sha256-bOm82mBUIaw4BGHj3Y24Fv5+RfAew+Ma1u4QENXoRiU=";
};

prePatch = ''
substituteInPlace setup.py \
--replace 'library_dirs=library_dirs' 'library_dirs=[dir.decode("utf-8") for dir in library_dirs]' \
--replace 'include_dirs=include_dirs' 'include_dirs=[dir.decode("utf-8") for dir in include_dirs]' \
--replace 'runtime_library_dirs=runtime_lib_dirs' 'runtime_library_dirs=[dir.decode("utf-8") for dir in runtime_lib_dirs]'
'';

preConfigure = ''
patchShebangs .
'';

build-system = [ setuptools ];

nativeBuildInputs = [
nose
pkgs.pkg-config
pkgs.swig
pkg-config
swig
];

buildInputs = [
setuptools
pkgs.libcdio
] ++ lib.optional stdenv.isDarwin pkgs.libiconv;

# Run tests using nosetests but first need to install the binaries
# to the root source directory where they can be found.
checkPhase = ''
Sigmanificient marked this conversation as resolved.
Show resolved Hide resolved
./setup.py install_lib -d .
nosetests
'';
libcdio
libiconv
];

nativeCheckInputs = [ pytestCheckHook ];

pytestFlagsArray = [ "test/test-*.py" ];

meta = with lib; {
meta = {
homepage = "https://www.gnu.org/software/libcdio/";
changelog = "https://github.com/rocky/pycdio/blob/${src.rev}/ChangeLog";
description = "Wrapper around libcdio (CD Input and Control library)";
license = licenses.gpl3Plus;
license = lib.licenses.gpl3Plus;
maintainers = with lib.maintainers; [ sigmanificient ];
};
}