Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nose2pytest: init at 1.0.12 #330725

Merged
merged 2 commits into from
Aug 1, 2024
Merged

nose2pytest: init at 1.0.12 #330725

merged 2 commits into from
Aug 1, 2024

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Jul 28, 2024

Description of changes

They said nobody could get a new package using nose into Nixpkgs… they were wrong!!!

Obviously there is an element of farce here, but I just used this to accomplish yandex/gixy#146 and I suspect it may come in handy for others working on #326513 or who just have their own nose test suites they’d like to migrate. The upstream package declares that it doesn’t work on Python 3.12, I guess because the nose‐using tests won’t natively run on that version, but it seems to work fine for me.

Of course, I’ll remove the nose nativeCheckInput and just disable the tests when the time comes. (Or now, if other people don’t find it as amusing as I do.)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM !

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how many active upstreams actually use nose in 2024, but it's fine for me to package it as long as the other packages in nixpkgs don't depend on it.

@natsukium natsukium merged commit 799bc8d into NixOS:master Aug 1, 2024
25 of 27 checks passed
@emilazy emilazy deleted the push-lsuzwplvkpsw branch August 26, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants